-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File export extension #14
Open
aiqui
wants to merge
14
commits into
etsy:master
Choose a base branch
from
aiqui:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+398
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation on the wiki, merged the latest changes from the base branch, and cleaned up code documentation. If there is anything missing, please let me know. Thank you! |
@etsy could somebody please merge this? Thank you! |
would be happy to take a look at merging this if you update this to use the new project structure, as well as adding some unit tests. |
Great, I'll get that up to date and let you know. I should have this in
place in the next week.
…On Mon, Mar 19, 2018 at 8:02 AM, jgedarovich ***@***.***> wrote:
would be happy to take a look at merging this if you update this to use
the new project structure, as well as adding some unit tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHQB_lA3HRWun_6ghI2X-V1pMuuRJLz-ks5tf55sgaJpZM4B7t14>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built this extension to phpunit over a year ago, and have been using it extensively. I hope it will be helpful to others out there. I added the documentation here:
https://github.com/etsy/phpunit-extensions/wiki/File-Export