Windows: Backslash in a path to contract leads to solc crash

[mbolotov]

Steps to reproduce:

1. Define two contracts:

contract A {}

import "./A.sol";
contract B {}

2. Run the following command:
   solc -o . --bin .\A.sol B.sol

Expected result:

Contracts to be compiled successfully

Actual result:

Solc crashed

Output:

Exception during output generation: C:\projects\solidity\solc\CommandLineInterface.cpp(524): Throw in function void __cdecl dev::solidity::CommandLineInterface::createFile(const class std::bas
ic_string<char,struct std::char_traits,class std::allocator > &,const class std::basic_string<char,struct std::char_traits,class std::allocator > &)
Dynamic exception type: class boost::exception_detail::clone_impl
std::exception::what: FileError
[struct dev::tag_comment * __ptr64] = Could not write to file: ._\A_sol_A.bin

solc version:

0.4.23+commit.124ca40d.Windows.msvc

platform:

win7

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $7,939.56 more funded OSS Work available on the Gitcoin Issue Explorer

[GaretWebster]

I assume you already read through this, but just incase I wanted to link Solidities documentation on this issue - https://solidity.readthedocs.io/en/latest/layout-of-source-files.html#paths

I also noticed that you have a forward slash in one of your example and a backslash in another, could you have gotten them mixed up?

Finally is it possible back slashes have another meaning in Soliditiy and need to be escaped to work properly?

[mbolotov]

I'm aware that Solidity import statement accepts only forward slashes.
That being said when you run solc from command line the command must obey the OS path rules. And Windows defines backslash as a primary path separator character (though supporting / as well)
So I believe that my example is valid and moreover the most correct way to call solc in the mentioned example.

Just to clarify this: I'm quite sure if I tried call solc manually I would use a forward slash. But I found this bug when called solc programmatically from java.
And it generated a path with backslashes since java tries to conform to the specs as much as possible.
So I had to workaround this issue by converting \ to / explicitely

[chriseth]

I agree, the commandline interface should support both backslashes and forward slashes on windows, while import statements should only support forward slashes. This should all be taken care of by boost::filesystem, it just looks like there is a bug about how we distinguish directories and files.

[gitcoinbot]

@asifmallik Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@asifmallik due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vs77bb]

Hi @asifmallik we see you've created a PR here - are you able to close the loop on the tests @axic has requested? Hope you're doing well!

@chriseth Let me know if you think I'm missing something here 😄

[asifmallik]

@vs77bb Sorry, I had been busy in the last couple of days. I am looking into it right now!

[gitcoinbot]

@asifmallik Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@asifmallik Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@asifmallik due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@asifmallik Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@asifmallik due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[mxmauro]

Using forward slashes does not solve the issue.

[cnusrini]

Is this still an open issue? Of not, I would like to try. Please confirm.

[chriseth]

@cnusrini please coordinate with @asifmallik , they were still working on #4070 two weeks ago.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 2 days, 22 hours from now.
Please review their action plans below:

1) asifmallik has started work.

I have fixed this bug by replacing the string() method with generic_string() to ensure backslash separated paths are also internally represented as paths separated with forward slashes.

Learn more on the Gitcoin Issue Details page.

[chriseth]

I confirm that it has been solved by @asifmallik

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 75.0 DAI (75.0 USD @ $1.0/DAI) has been submitted by:

1. @asifmallik

@gdipri01 please take a look at the submitted work:

• PR by @asifmallik

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $19,386.10 more funded OSS Work available on the Gitcoin Issue Explorer

[asifmallik]

@gdipri01 could you please release the bounty?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @asifmallik.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $57,574.06 more funded OSS Work available on the Gitcoin Issue Explorer