Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/filters: replace atomic pointer with value #26689

Merged
merged 3 commits into from
Feb 14, 2023
Merged

eth/filters: replace atomic pointer with value #26689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfe25bb
eth/filters: replace atomic.Pointer
s1na Feb 14, 2023
11aa544
fix
s1na Feb 14, 2023
9e5a437
improve
s1na Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eth/filters/filter_system.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func NewFilterSystem(backend Backend, config Config) *FilterSystem {

type logCacheElem struct {
logs []*types.Log
body atomic.Pointer[types.Body]
body atomic.Value
}

// cachedLogElem loads block logs from the backend and caches the result.
Expand Down Expand Up @@ -133,7 +133,7 @@ func (sys *FilterSystem) cachedLogElem(ctx context.Context, blockHash common.Has

func (sys *FilterSystem) cachedGetBody(ctx context.Context, elem *logCacheElem, hash common.Hash, number uint64) (*types.Body, error) {
if body := elem.body.Load(); body != nil {
return body, nil
return body.(*types.Body), nil
}
body, err := sys.backend.GetBody(ctx, hash, rpc.BlockNumber(number))
if err != nil {
Expand Down