Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: fix trace config for TraceCall #25821

Merged
merged 4 commits into from
Sep 21, 2022
Merged

eth: fix trace config for TraceCall #25821

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39f52c5
eth: fix trace config for `TraceCall`
makcandrov Sep 19, 2022
add360b
eth: fix config types in `TraceCall`
makcandrov Sep 19, 2022
81adbe8
eth/tracers: restore previous `config.Reexec` nil check
makcandrov Sep 20, 2022
87161c0
eth/tracers: restore previous config.Reexec nil check
makcandrov Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions eth/tracers/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ func (api *API) TraceCall(ctx context.Context, args ethapi.TransactionArgs, bloc
// try to recompute the state
reexec := defaultTraceReexec
if config != nil && config.Reexec != nil {
makcandrov marked this conversation as resolved.
Show resolved Hide resolved
reexec = *config.Reexec
reexec = *config.TraceConfig.Reexec
makcandrov marked this conversation as resolved.
Show resolved Hide resolved
}
statedb, release, err := api.backend.StateAtBlock(ctx, block, reexec, nil, true, false)
if err != nil {
Expand All @@ -895,12 +895,7 @@ func (api *API) TraceCall(ctx context.Context, args ethapi.TransactionArgs, bloc

var traceConfig *TraceConfig
if config != nil {
traceConfig = &TraceConfig{
Config: config.Config,
makcandrov marked this conversation as resolved.
Show resolved Hide resolved
Tracer: config.Tracer,
Timeout: config.Timeout,
Reexec: config.Reexec,
}
traceConfig = &config.TraceConfig
}
return api.traceTx(ctx, msg, new(Context), vmctx, statedb, traceConfig)
}
Expand Down