discv5 wormhole
#25798
Closed
discv5 wormhole
#25798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use kcp standard implementation for writing out
In readLoop, we use a single buffer for all packets. This is fine for the uses of this buffer in UDPv5, but we cannot know how the reading end of the 'unhandled' channel behaves, so must send a copy there.
Use kcp.NewConn3 for both client and server side, it accepts net.Addr directly. Since we use TALKREQ to initiate the connection, the remote address is available.
fjl
added a commit
that referenced
this pull request
Dec 6, 2022
The new flag allows configuring an explicit endpoint which is to be announced in the DHT. This feature was originally developed for the discv5 wormhole experiment (#25798), but it's useful in other contexts as well.
|
@fjl why did you close this?? |
|
I closed it because it was an experiment! I don't think we intend to ship it as a feature in cmd/devp2p? |
|
I actually wanted this... 😢 |
|
We can always develop this further as a standalone tool! The prototype doesn't depend on any go-ethereum internals. It can also be added as a subcommand of cmd/devp2p, but I'd want to do some further development before that. Either way, to get this in, we'd need to submit the p2p/discover fixes for |
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
The new flag allows configuring an explicit endpoint which is to be announced in the DHT. This feature was originally developed for the discv5 wormhole experiment (ethereum#25798), but it's useful in other contexts as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip