Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind: add const for tx fee elasticity multiplier #25504

Merged
merged 6 commits into from
Aug 25, 2022
Merged

accounts/abi/bind: add const for tx fee elasticity multiplier #25504

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25a77bd
Use const for better readability
xinbenlv Aug 9, 2022
e424a9b
Update base.go
fjl Aug 10, 2022
b6be98f
Update base.go
fjl Aug 11, 2022
b5cd180
Update base.go
xinbenlv Aug 16, 2022
3afe489
Update base.go
xinbenlv Aug 18, 2022
af0d73e
Update base.go
rjl493456442 Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accounts/abi/bind/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ func (c *BoundContract) createDynamicTx(opts *TransactOpts, contract *common.Add
if gasFeeCap == nil {
gasFeeCap = new(big.Int).Add(
gasTipCap,
new(big.Int).Mul(head.BaseFee, big.NewInt(2)),
new(big.Int).Mul(head.BaseFee, big.NewInt(params.ElasticityMultiplier)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to import params, otherwise this is a build failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know without import params, it will be build failure. May I clarify with you that you intend to pass down the params all the way from the call stack?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params is a package, ElasticityMultiplier is a global variable in it. You don't need to pass anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add "github.com/ethereum/go-ethereum/params" to the import list and it will work. (If you configure your editor to run goimports on save, it would automatically add it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempted to update to use params. elasticityMultiplier but it seems params is not avaialble in this local context. Would it be your advice to add params all the way through the call-stack?

)
}
if gasFeeCap.Cmp(gasTipCap) < 0 {
Expand Down