eth/filters: annotate logs in a sub with block end markers #24823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Ugh, so this doesn't actually work, because the
*types.Log
embedding redefines JSON marshalling, which overrides it even for the wrapper. UghFixes #24787
When subscribing to logs, the user will get a never ending stream of them. It can be annoying to figure out whether the last log of a block arrived, or if there's some more in the pipeline. This PR adds a block end marker into logs.