-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow file descriptor limit to be set via CLI #24477
Allow file descriptor limit to be set via CLI #24477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have left a few comments please check them.
32f08b5
to
349ae49
Compare
I modified the content of this PR according to your remakrs @rjl493456442 . |
349ae49
to
c6320c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
I'll take a closer look in a moment, I think the name will need a bit of a tweak since it only affects the db fd limit, not the global one. |
Nope, actually it refers to the global one. DB handler is still a half of it. |
Ah, good catch |
Thanks for the PR. I did take the liberty to simplify it and remove a bit of functionality.
|
* eth, cmd: allow FdLimit to be set in config/command line (ethereum#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohe:bugfix/allow_databasehandle_to_be_set_through_TOML
* eth, cmd: allow FdLimit to be set in config/command line (ethereum#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]>
* Port of ethereum/go-ethereum#24477, which will be picked up in a future release of Quorum. * We used to run with a different CLI option `--dbhandles`, I have retired that and used the same name as used in the upstream repo now that there is a CLI option for the same.
* Port of ethereum/go-ethereum#24477, which will be picked up in a future release of Quorum. * We used to run with a different CLI option `--dbhandles`, I have retired that and used the same name as used in the upstream repo now that there is a CLI option for the same.
* Port of ethereum/go-ethereum#24477, which will be picked up in a future release of Quorum. * We used to run with a different CLI option `--dbhandles`, I have retired that and used the same name as used in the upstream repo now that there is a CLI option for the same.
* eth, cmd: allow FdLimit to be set in config/command line (ethereum#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]>
* Port of ethereum/go-ethereum#24477, which will be picked up in a future release of Quorum. * We used to run with a different CLI option `--dbhandles`, I have retired that and used the same name as used in the upstream repo now that there is a CLI option for the same.
* Port of ethereum/go-ethereum#24477, which will be picked up in a future release of Quorum. * We used to run with a different CLI option `--dbhandles`, I have retired that and used the same name as used in the upstream repo now that there is a CLI option for the same.
This PR is an attempt to solve issue #24148 by allowing DatabaseHandles to be set via the Config file or the Command line interface.
By default, DatabaseHandles is set to MaxInt32. If no setting is passed (in TOML or CLI), it will be set to
fdlimit.Maximum
. Otherwise, the lower number between DatabaseHandles parameter &fdlimit.Maximum
will be set.