Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ethereum.js RPC method names #144

Closed
obscuren opened this issue Oct 20, 2014 · 0 comments
Closed

Update ethereum.js RPC method names #144

obscuren opened this issue Oct 20, 2014 · 0 comments
Milestone
PoC7

Comments

@obscuren
Copy link
Contributor

Methods should drop "get" prefix
@obscuren obscuren modified the milestone: PoC7 Oct 22, 2014
@obscuren obscuren added the ready label Oct 27, 2014
@obscuren obscuren closed this as completed Nov 2, 2014
@obscuren obscuren removed the ready label Nov 2, 2014
joelburget pushed a commit to joelburget/go-ethereum that referenced this issue Aug 16, 2017
@gsalgado @joelburget
Fix TestPrivateTransaction to actually create private transactions (e…
1af69f8 
…thereum#144)

It now creates private transactions, but that means it now needs to run
constellation in a subprocess, so do that as well
joelburget pushed a commit to joelburget/go-ethereum that referenced this issue Aug 24, 2017
@gsalgado @joelburget
Fix TestPrivateTransaction to actually create private transactions (e…
687d5ca 
…thereum#144)

It now creates private transactions, but that means it now needs to run
constellation in a subprocess, so do that as well
stevenroose pushed a commit to stevenroose/go-ethereum that referenced this issue Sep 14, 2017
@gsalgado @patrickmn
Fix TestPrivateTransaction to actually create private transactions (e…
2ea6e55 
…thereum#144)

It now creates private transactions, but that means it now needs to run
constellation in a subprocess, so do that as well
roveneliah pushed a commit to roveneliah/go-ethereum that referenced this issue May 30, 2018
@terencechain
Merge pull request ethereum#144 from prysmaticlabs/update-active-rese…
96c33ea 
…arch

Update Active Research Section in Sharding README.md
AusIV pushed a commit to NoteGio/go-ethereum that referenced this issue May 21, 2020
@meowsbits
core/vm,params/vars: implement missing SLOAD gas cost change (ethereu…
0cd6b91 
…m#144)

- https://eips.ethereum.org/EIPS/eip-2200
- https://eips.ethereum.org/EIPS/eip-1884

EIP2200 is implemented simultaneously with 1884
on the ETH nets, rendering this somewhat redundant.
But other networks may care, and this changeset
should be handled carefully, since either or both
2200 1884 may be live with or without the other.

Signed-off-by: meows <[email protected]>
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Aug 13, 2021
@tynes
verifier: docs and simple start script (ethereum#144)
bfc80bf 
* verifier: docs and simple start script

* readme: updates

* readme: regensis repo
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@ashishb
Fix bugs related to gas fees (ethereum#144)
e48dad5 
When paying gas fees in C$ or any other non-native currency

1. Charge the user upfront for three things
   - balanceOf - to determine their balance in that currency)
   - debitFrom - to debit gas from their account
   - creditTo - to credit miner at the end

2. At the end if the fee to be refunded is less than the transaction fee
to refund then pass that fee to the miner.

Prior to this diff, ethereum#1 was not happening properly and ethereum#2 was not
happening at all.

As a more concrete example, if user passes 100K C$ wei as gas amount
for a send tranaction then we will deduct 2195 to determine their
balance in C$, then we will deduct 10,000 for a debitFrom transaction
and another 10K for a creditTo transaction.
So, the available gas (`st.gas`) would be
100,000 - 22,195 = 77,805 for rest of the transaction.

At the end, we will pay the gas fees to the miner, which in this case is
22,195 + 21,000 (send fee) = 43,195, at the end, 56,805 gas is left, out
of which 10, 000 is further deducted and then 46,805 is refunded to the
sender and 43, 195 + 10, 000 is sent to the miner.

Sample logs with gas price = 999
```
DEBUG[03-21|18:18:51.003|core/state_transition.go:252]           debitGas                                 amount=99900000 gasCurrency=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4
TRACE[03-21|18:18:51.003|core/state_transition.go:262]           debitGas                                 rootCaller=0 customTokenContractAddress=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4 gas=10000 value=0 transactionData=0x362a5f80000000000000000000000000fee1a22f43beecb912b5a4912ba87527682ef0fc0000000000000000000000000000000000000000000000000000000005f45a60
DEBUG[03-21|18:18:51.003|core/state_transition.go:273]           debitGas successful                      ret=0x00000000000000000000000000000000000000000000006c4fd1ee2454c9dd59 leftoverGas=2351
TRACE[03-21|18:18:51.003|core/state_transition.go:192]           buyGas after debitGas                    upfrontGasCharges=22195 available gas=77805   initial gas=100000  gasCurrency=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4
TRACE[03-21|18:18:51.003|core/state_transition.go:463]           Refunding gas to sender                  sender=0xfeE1a22F43BeeCB912B5a4912ba87527682ef0fC refundAmount=46758195 gas Currency=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4
DEBUG[03-21|18:18:51.003|core/state_transition.go:252]           creditGas                                amount=46758195 gasCurrency=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4
TRACE[03-21|18:18:51.003|core/state_transition.go:262]           creditGas                                rootCaller=0 customTokenContractAddress=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4 gas=10000 value=0 transactionData=0x9951b90c000000000000000000000000fee1a22f43beecb912b5a4912ba87527682ef0fc0000000000000000000000000000000000000000000000000000000002c97933
DEBUG[03-21|18:18:51.004|core/state_transition.go:273]           creditGas successful                     ret=0x00000000000000000000000000000000000000000000006c4fd1ee245793568c leftoverGas=2057
TRACE[03-21|18:18:51.004|core/state_transition.go:425]           Paying gas fees to miner                 unrefundedGas=0 gas used=53195 gasFeesForMiner=53195 miner Fee=53141805
TRACE[03-21|18:18:51.004|core/state_transition.go:428]           Paying gas fees to miner                 miner=0xfeE1a22F43BeeCB912B5a4912ba87527682ef0fC minerFee=53141805 gas Currency=0x13f252CFCd0AED2FBAdAE507AA812aa1De01d8a4
```
joshuacolvin0 pushed a commit to joshuacolvin0/go-ethereum that referenced this issue Jan 4, 2023
@PlasmaPower
Merge pull request ethereum#144 from OffchainLabs/export-revert-reason
9a07d0b 
Export NewRevertReason function
sbellem pushed a commit to sbellem/go-ethereum that referenced this issue Jul 25, 2023
@dartdart26
Merge pull request ethereum#144 from zama-ai/petar/cast-on-gas-estima…
1c5fa4f 
…tion

Do not try to cast if we are doing gas estimation
come-maiz pushed a commit to come-maiz/go-ethereum that referenced this issue Sep 19, 2024
@fearlessfe
Merge pull request ethereum#144 from fearlessfe/beacon_validate
3b626a8 
Beacon validate
s1na pushed a commit to s1na/go-ethereum that referenced this issue Dec 2, 2024
@olumuyiwadad
Merge pull request ethereum#144 from XinFinOrg/dev-upgrade
ac7b764 
fetch dev-upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PoC7
Development

No branches or pull requests
1 participant
@obscuren