Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forks,tests): EIP-7251, EIP-7002, EIP-2935 Spec Updates #1024

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 16, 2024

🗒️ Description

Update tests for EIP-7251, EIP-7002 EIP-2935 to match the following spec updates:

🔗 Related Issues

#956

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz requested a review from danceratopz December 16, 2024 23:28
@marioevz marioevz force-pushed the eip-7251-eip-2935-contracts-update branch from 9779151 to 2cdccc4 Compare December 18, 2024 22:43
@marioevz marioevz changed the title fix(forks,tests): EIP-7251, EIP-2935 Spec Updates fix(forks,tests): EIP-7251, EIP-7002, EIP-2935 Spec Updates Dec 18, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Crazy deployment tests :) will spend more time on these when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants