Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to Apache 2.0 #77

Merged
merged 3 commits into from
Aug 23, 2018
Merged

Change license to Apache 2.0 #77

merged 3 commits into from
Aug 23, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 22, 2018

A proposal to change license from MIT to Apache 2.0.
This is mostly to be consistent with other projects we created recently.

I need approvals from @axic @ehildenb and @gumb0.

Closes #60.

@chfast chfast requested review from axic, ehildenb and gumb0 August 22, 2018 12:17
@ehildenb
Copy link

ehildenb commented Aug 22, 2018

@chfast it looks like you're supposed to include this entire block of text at the top of each file:

   Copyright [yyyy] [name of copyright owner]

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.

   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.

@chfast
Copy link
Member Author

chfast commented Aug 22, 2018

I'm ignoring this, too much lines.

@chfast
Copy link
Member Author

chfast commented Aug 22, 2018

I prefer 2 lines only. I think it is quite clear what the license is. I've see in it some Google projects:
https://github.com/golang/go/blob/master/src/sync/map.go#L1-L3

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure which is better for this project, but I do not mind either.

@chfast
Copy link
Member Author

chfast commented Aug 22, 2018

@ehildenb Are you ok with this?

Copy link

@ehildenb ehildenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should include the full text that the license assumes, but the switch seems ok too.

@chfast chfast merged commit 0ff7c38 into master Aug 23, 2018
@chfast chfast deleted the apache-license branch August 23, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants