Add gas refund to evmc_result #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
approved these changes
Aug 16, 2022
The evmc_result::gas_refund represents refunded gas accumulated from the current execution and its sub-calls.
axic
reviewed
Aug 22, 2022
| @@ -345,33 +345,39 @@ class Result : private evmc_result | |||
| /// | |||
| /// @param _status_code The status code. | |||
| /// @param _gas_left The amount of gas left. | |||
| /// @param _gas_refund The amount of refunded gas. | |||
There was a problem hiding this comment.
Does gas_left includes the gas_refund value?
There was a problem hiding this comment.
No. It is mentioned somewhere that gas refund is uncapped. I can try to improve the documentation.
This is implementable, but I decided to leave the transaction-specific logic outside of EVMC yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
gas_refundfield toevmc_resultandevmc::Result.Closes #413.
Replaces #417