tool: Use @file syntax to loading data from a file #647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 92.86% 92.84% -0.02%
==========================================
Files 23 23
Lines 3546 3552 +6
Branches 375 376 +1
==========================================
+ Hits 3293 3298 +5
Misses 144 144
- Partials 109 110 +1 |
For --input and code arguments allow loading data from a file by preceding the file path with @ character. E.g. `--input @sha1.in`.
| func_ = [](const std::string& str) -> std::string { | ||
| if (!str.empty() && str[0] == '@') | ||
| return CLI::ExistingFile(str.substr(1)); |
There was a problem hiding this comment.
Shouldn't this try to load & verify the content?
There was a problem hiding this comment.
It could but it feels too much. I don't know any CLI library doing so. And you would need to load the file twice.
There was a problem hiding this comment.
Since the files are usually small, the overhead may be worth it here for easy-of-use (and not relying on exceptions).
tools/evmc/main.cpp
Outdated
| return str; | ||
| if (str[0] == '@') // The argument is file path. | ||
| { | ||
| std::ifstream file{str.c_str() + 1}; |
There was a problem hiding this comment.
Why use c_str() + 1 here and substr(1) below?
There was a problem hiding this comment.
Here the constructor of const char* is available.
There was a problem hiding this comment.
I actually changed this to add more info to the error.
Change the type of code and input parameters of tooling::run() from hex-encoded string to bytes. The hex decoding must happen outside. This moves the hex decoding errors out of the function concern.
For
--inputandcodearguments allow loading data from a file by preceding the file path with @ character. E.g.--input @sha1.in.Change the type of code and input parameters of
tooling::run()from hex-encoded string to bytes. The hex decoding must happen outside. This moves the hex decoding errors out of the function concern.