Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental PRECOMPILES capability #267

Merged
merged 2 commits into from
May 9, 2019
Merged

Add experimental PRECOMPILES capability #267

merged 2 commits into from
May 9, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented May 8, 2019 •
edited by axic
Loading

Part of #259.

@chfast chfast requested a review from axic May 8, 2019 11:49
@chfast
Copy link
Member Author

chfast commented May 8, 2019

I want to create a basic example of "Precompiles VM" implementation. Let me finish the full example first and the decide what can be merged to the master branch.

@chfast

This comment has been minimized.

Sign in to view
@chfast chfast force-pushed the precompiles-capacity branch 2 times, most recently from 24e33d0 to feb9ef7 Compare May 8, 2019 13:59
@chfast

This comment has been minimized.

Sign in to view
axic
axic requested changes May 8, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should run the vmtester on the example (also need to extend the vmtester to cope with this).

@chfast chfast mentioned this pull request May 8, 2019
Merged
@chfast chfast force-pushed the precompiles-capacity branch 2 times, most recently from ac85b48 to 3bbeb9b Compare May 8, 2019 21:37
axic
axic reviewed May 9, 2019
View reviewed changes
test/vmtester/tests.cpp Outdated Show resolved Hide resolved
axic
axic approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I assume you'll squash some of the commits.

@chfast chfast force-pushed the precompiles-capacity branch from b79037e to 5f86929 Compare May 9, 2019 12:25
@chfast
Copy link
Member Author

chfast commented May 9, 2019

Squashed. Do you think we should merge this?

@chfast chfast force-pushed the precompiles-capacity branch from db0c517 to 2e9bd6f Compare May 9, 2019 14:04
@chfast chfast merged commit b4a04e8 into master May 9, 2019
@chfast chfast deleted the precompiles-capacity branch May 9, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic