Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Host Implementation Guide #159

Merged
merged 3 commits into from
Oct 15, 2018
Merged

docs: Host Implementation Guide #159

merged 3 commits into from
Oct 15, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 5, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- Do not explicitly skip .git dir, all . files are ignored by default.
- Set quiet level mask to 4 to ignore misspells that are disabled for automatic correction. In this case we want to allow "uint".
The implementation can be done in object-oriented manner.
The ::evmc_host_interface lists the methods any Host must implement.

Moreover, each of methods has a pointer to ::evmc_context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each of the methods

The ::evmc_host_interface lists the methods any Host must implement.

Moreover, each of methods has a pointer to ::evmc_context
as a parameter. The context is owned entirely to the Host allowing a Host instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owned entirely by the Host or belongs entirely to the Host

@chfast chfast merged commit 1933836 into master Oct 15, 2018
@chfast chfast deleted the host-guide branch October 15, 2018 13:00
@axic
Copy link
Member

axic commented Oct 22, 2018

Comments about codespell change:

  • Do not explicitly skip .git dir, all . files are ignored by default.

Perhaps with a different version of codespell, it did consume .git on my computer when I added the commit.

  • Set quiet level mask to 4 to ignore misspells that are disabled for automatic correction. In this case we want to allow "uint".

There is a whitelist file to allow specific things which are caught by it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants