Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all trailing whitespace & add CI check #3977

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Delete all trailing whitespace & add CI check #3977

merged 6 commits into from
Dec 2, 2024

Conversation

jtraglia
Copy link
Member

This PR deletes all of the trailing whitespace (spaces at the end of a line) throughout the repo. There's also a new CI check which greps for trailing whitespace and errors if any is found.

@jtraglia jtraglia added general:presentation Presentation (as opposed to content) general:proofread spelling, grammar, accuracy and removed general:presentation Presentation (as opposed to content) labels Oct 11, 2024
@jtraglia jtraglia requested a review from hwwhww October 14, 2024 14:06
hwwhww
hwwhww approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I like clean-ups, this PR would make the "release diff" of the next release include these unrelated stuff.

Good to merge it in a small Pectra-only release.

ppopth
ppopth approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtraglia jtraglia mentioned this pull request Oct 18, 2024
Merged
@jtraglia jtraglia merged commit 6fedfc6 into ethereum:dev Dec 2, 2024
27 checks passed
@jtraglia jtraglia deleted the delete-trailing-whitespace branch December 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@ppopth ppopth ppopth approved these changes

Assignees
No one assigned
Labels
general:proofread spelling, grammar, accuracy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @ppopth @hwwhww