Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_incorrect_not_enough_consolidation_churn_available and add assertions to test cases #3814

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jun 24, 2024

  1. @ensi321 reported that test_incorrect_not_enough_consolidation_churn_available test made Lodestar determine it's invalid state because state.current_sync_committee still has 48 pubkeys. I removed state.validators = state.validators[0:2] as @ensi321 suggested.
  2. Add more assertions to check if the test cases satisfy the testing targets.

Copy link
Contributor

@fradamt fradamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hwwhww hwwhww merged commit 29f3948 into dev Jun 26, 2024
26 checks passed
@hwwhww hwwhww deleted the update-consolidation-tests branch June 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants