Extract sync committee period <-> slot helpers to common LC test module #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two functions `compute_start_slot_at_sync_committee_period` and `compute_start_slot_at_next_sync_committee_period` are currently only available during LC `test_sync`. Move them to the common LC test module so that they can be used from future tests as well.
dapplion
approved these changes
Jan 10, 2024
hwwhww
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two functions
compute_start_slot_at_sync_committee_periodandcompute_start_slot_at_next_sync_committee_periodare currently only available during LCtest_sync. Move them to the common LC test module so that they can be used from future tests as well.