Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] release v1.4.0-beta.3 #3523

Merged
merged 37 commits into from
Oct 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f82a440
Use engine API-compatible FIELD_ELEMENTS_PER_BLOB in minimal preset
tersec Feb 16, 2023
4fa396d
Update testing_trusted_setups.json
hwwhww Feb 16, 2023
c7ac9cc
Fix `compute_quotient_eval_within_domain` overflow
hwwhww Feb 16, 2023
baaab93
Merge branch 'dev' into pr3255
hwwhww Mar 10, 2023
8900127
Remove the wrong store time setting
hwwhww Sep 19, 2023
6041c9b
Add KZGProof at `G1_POINT_AT_INFINITY` case
hwwhww Sep 19, 2023
ba61651
Merge pull request #3508 from ethereum/fix-deneb-fc-simple
hwwhww Sep 19, 2023
171ae02
Apply suggestions from code review
hwwhww Sep 19, 2023
256367b
Group the "incorrect_proof" test cases
hwwhww Sep 19, 2023
395bb71
Add `verify_kzg_proof_case_incorrect_proof_point_at_infinity`
hwwhww Sep 19, 2023
69d34dc
Merge pull request #3507 from ethereum/kzg-tests
hwwhww Sep 19, 2023
28e3c80
Update validator.md (#3509)
joethechicken Sep 20, 2023
a2d500f
generators/kzg_4844: Add positive G1_POINT_AT_INFINITY test vectors
asn-d6 Sep 22, 2023
0052e68
Fix linter error
hwwhww Sep 25, 2023
b044303
Merge pull request #3513 from asn-d6/testgen_kzg_4844_positive_g1_at_inf
hwwhww Sep 26, 2023
f958c5f
Merge branch 'dev' into pr3255
hwwhww Oct 10, 2023
fd082ae
Delete `test_compute_kzg_proof_within_domain`
hwwhww Oct 10, 2023
8acb254
Use add_validator_to_registry in whisk (#3486)
dapplion Oct 10, 2023
09983a4
Revive test_compute_kzg_proof_within_domain() -- but not exhaustive
asn-d6 Oct 10, 2023
be3c0f7
Also make test_barycentric_within_domain() not exhaustive
asn-d6 Oct 10, 2023
c578589
Use official KZG ceremony output `trusted_setup_4096.json` trusted se…
hwwhww Oct 12, 2023
01fa0fe
Replace `ROOTS_OF_UNITY` with runtime-computed `compute_roots_of_unit…
hwwhww Oct 16, 2023
9257ad2
Rename `KZG_SETUP_LAGRANGE` to `KZG_SETUP_G1_LAGRANGE` and `KZG_SETUP…
hwwhww Oct 16, 2023
8d6b28b
set default bls lib to `fastest_bls`
hwwhww Oct 16, 2023
bae3384
Fix typos
shuoer86 Oct 16, 2023
65e1371
Fix tests
hwwhww Oct 16, 2023
63aa303
consistent naming
hwwhww Oct 16, 2023
9356e82
Merge pull request #3522 from shuoer86/dev
hwwhww Oct 16, 2023
a361aff
Delete leftover
hwwhww Oct 17, 2023
4ebd1bd
bump VERSION.txt
djrtwo Oct 17, 2023
3cab9ed
Remove the "TBD" note
hwwhww Oct 17, 2023
8d91941
Merge branch 'dev' into official-kzg
hwwhww Oct 17, 2023
0002f43
Merge pull request #3521 from ethereum/official-kzg
hwwhww Oct 18, 2023
d18b86c
Merge pull request #3524 from ethereum/bump-version-1
hwwhww Oct 18, 2023
27ad39b
Add new gossip rule to `REJECT` sidecars with index >= MAX_BLOBS_PER_…
tbenr Oct 18, 2023
a2d021d
re-order conditions
djrtwo Oct 18, 2023
1e552f1
Merge pull request #3525 from tbenr/patch-1
djrtwo Oct 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
re-order conditions
djrtwo authored Oct 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a2d021da484450547bc159cbdff8fa9ead848b80
2 changes: 1 addition & 1 deletion specs/deneb/p2p-interface.md
Original file line number Diff line number Diff line change
@@ -148,8 +148,8 @@ This topic is used to propagate signed blob sidecars, where each blob index maps

The following validations MUST pass before forwarding the `signed_blob_sidecar` on the network, assuming the alias `sidecar = signed_blob_sidecar.message`:

- _[REJECT]_ The sidecar is for the correct subnet -- i.e. `compute_subnet_for_blob_sidecar(sidecar.index) == subnet_id`.
- _[REJECT]_ The sidecar's index is consistent with `MAX_BLOBS_PER_BLOCK` -- i.e. `sidecar.index < MAX_BLOBS_PER_BLOCK`.
- _[REJECT]_ The sidecar is for the correct subnet -- i.e. `compute_subnet_for_blob_sidecar(sidecar.index) == subnet_id`.
- _[IGNORE]_ The sidecar is not from a future slot (with a `MAXIMUM_GOSSIP_CLOCK_DISPARITY` allowance) -- i.e. validate that `sidecar.slot <= current_slot` (a client MAY queue future sidecars for processing at the appropriate slot).
- _[IGNORE]_ The sidecar is from a slot greater than the latest finalized slot -- i.e. validate that `sidecar.slot > compute_start_slot_at_epoch(state.finalized_checkpoint.epoch)`
- _[IGNORE]_ The sidecar's block's parent (defined by `sidecar.block_parent_root`) has been seen (via both gossip and non-gossip sources) (a client MAY queue sidecars for processing once the parent block is retrieved).