Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[smock]: add support for overloaded functions #966

Merged
merged 2 commits into from
May 27, 2021

Conversation

smartcontracts
Copy link
Contributor

Description
Fixes a bug where smock would not correctly handle overloaded functions. Let's call this a feature. Yay!

@smartcontracts smartcontracts requested a review from maurelian as a code owner May 27, 2021 00:10
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2021

🦋 Changeset detected

Latest commit: 8b762be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/smock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Merging #966 (8b762be) into develop (c84d345) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #966   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84d345...8b762be. Read the comment docs.

Copy link
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much--this LGTM!

@ben-chain ben-chain merged commit e6e87ae into develop May 27, 2021
@ben-chain ben-chain deleted the kelvin/smock-overloaded-functions branch May 27, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants