Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds test that gas estimation is deterministic #962

Merged
merged 2 commits into from
May 26, 2021

Conversation

gakonst
Copy link
Contributor

@gakonst gakonst commented May 26, 2021

Adding another sanity check for gas estimation.

@gakonst gakonst requested a review from tynes as a code owner May 26, 2021 17:29
@changeset-bot
Copy link

changeset-bot bot commented May 26, 2021

⚠️ No Changeset found

Latest commit: 5fcab87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Merging #962 (aa49148) into develop (a25acbb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #962   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25acbb...aa49148. Read the comment docs.

@gakonst gakonst merged commit c84d345 into develop May 26, 2021
@gakonst gakonst deleted the test/estimate-gas-determinism branch May 26, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants