feat(ctb): Refactor L1 initializer tests #8198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #8198 +/- ##
===========================================
- Coverage 53.44% 53.35% -0.10%
===========================================
Files 162 114 -48
Lines 6040 3758 -2282
Branches 964 813 -151
===========================================
- Hits 3228 2005 -1223
+ Misses 2690 1677 -1013
+ Partials 122 76 -46
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Oddly enough, the gas snapshot for this test differs depending on the host architecture, tested on darwin aarch64 + linux x86_64. Omitting this from the gas snapshot. |
refcell
approved these changes
Nov 20, 2023
mds1
reviewed
Nov 20, 2023
|
What do you think about also testing the L2 predeploys using this method? |
clabby
force-pushed
the
cl/ctb/reinit-tests
branch
from
7e00716 to
2eb4a03
Compare
mds1
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors the
test_cannotReinitializeL1_succeedstest to account for all L1 contracts which areInitializable.The new test covers:
Initializablecontracts insrc/L1are accounted for in thecontractsarray, giving us assurance that we have full coverage of L1 contracts' reinitializers._initializedflag of each contract is properly set to3at the start of the test, signifying that the contracts are initialized by the deploy script.initialize()function of each contract cannot be called more than once - each attempt should result in a revert message of the formatError(string), with the message "Initializable: contract is already initialized".Metadata
Closes https://github.com/ethereum-optimism/client-pod/issues/214