-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: Span Batch Derivation #7289
op-node: Span Batch Derivation #7289
Conversation
Hey @ImTei! This PR has merge conflicts. Please fix them before continuing review. |
Add L2GenesisSpanBatchTImeOffset into deploy config Activate SpanBatch hardfork for e2e tests by OP_E2E_USE_SPAN_BATCH env
Define SpanBatch and related types Rename BatchV1 to SingularBatch Add unit test cases
077a95c
to
2d53a35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a few comments about testing and edge-cases to harden against. I will do a second review pass later, since the derivation code is quite critical.
Adding a do-not-merge label to give others the chance to review as well. |
Rename advanceEpoch() to advanceEpochMaybe() Set number of calls for L2 client mock and assert them in batch queue tests
Opened #7621 to resolve conflicts with Follow-ups to implement after this PR:
|
Closing in favor of #7621 |
Span batch derivation [by Test In Prod, rebased on develop, see #7289]
Contexts
This PR contains the derivation code for Span Batch.
Please refer to the Implementations - Derivation and Hard Fork Activation sections of the Design Docs and op-node section of Implementation Design Docs for details & rationales.
This PR has a dependency on the Span Batch Type, Encoding, and Decoding PR.
Changes
op-node
section of Implementation Design Docs for details.Derivation
category in the Test List Sheet for each test’s details.