fix(indexer): Fix uri util #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roninjin10
commented
Sep 14, 2023
•
roninjin10
commented
- fix bug with putting a / before query string
- update json tags to beCorrectCasing
- Add test
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review. |
mergify
bot
added
S-conflict
hamdiallam
approved these changes
Sep 14, 2023
|
This PR has been added to the merge queue, and will be merged soon. |
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
from
c17ea5a to
14da1e7
Compare
mergify
bot
removed
S-conflict
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
from
14da1e7 to
98b0cdd
Compare
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
3 times, most recently
from
5ddb657 to
a02e81d
Compare
roninjin10
changed the base branch from
develop
to
09-14-fix_indexer_Fix_tygo_check_in_ci
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
from
a02e81d to
7cbdace
Compare
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
2 times, most recently
from
1f5e1e8 to
b40ec5e
Compare
Base automatically changed from
09-14-fix_indexer_Fix_tygo_check_in_ci
to
develop
September 15, 2023 16:47
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
from
6aacc02 to
4ed98d3
Compare
|
@roninjin10 offline instal is breaking CI for this |
hamdiallam
approved these changes
Sep 15, 2023
added 2 commits
September 15, 2023 12:52
roninjin10
force-pushed
the
09-14-fix_indexer_Fix_uri_util
branch
from
4ed98d3 to
5e2b2d0
Compare
|
@trianglesphere typo meant to do --prefer-offline not --offline |
trianglesphere
approved these changes
Sep 15, 2023
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.