-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ctb): Preserve prod game type space #6909
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6909 +/- ##
===========================================
- Coverage 44.84% 42.62% -2.22%
===========================================
Files 376 337 -39
Lines 29555 28358 -1197
Branches 1692 1541 -151
===========================================
- Hits 13254 12089 -1165
- Misses 14859 14861 +2
+ Partials 1442 1408 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a78ab45
to
07a5499
Compare
2ae988a
to
246411c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but probably worth updating the op-challenger/scripts/alphabet/init_script.sh
to have the new alphabet game type as well.
Semgrep found 1
Please create a Linear ticket for this TODO. Ignore this finding from todos_require_linear.Semgrep found 1
Leaky use of time.After in for-select, see: https://groups.google.com/g/golang-nuts/c/cCdm0Ixwi9A/m/jMiJJScAEAAJ Ignore this finding from leaky-time-after. |
This PR has been added to the merge queue, and will be merged soon. |
Overview
Moves the alphabet game to game ID
255
on the devnet and the cannon game to0
, making the game impls that will be deployed to prod have the same game IDs on devnet. Going forward, the devnet will maintain parity with prod game type values and any devnet-specific games will descend from255
.Metadata
Closes CLI-4369