Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ctb): Preserve prod game type space #6909

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Aug 18, 2023

Overview

Moves the alphabet game to game ID 255 on the devnet and the cannon game to 0, making the game impls that will be deployed to prod have the same game IDs on devnet. Going forward, the devnet will maintain parity with prod game type values and any devnet-specific games will descend from 255.

Metadata
Closes CLI-4369

@mergify mergify bot added A-op-e2e Area: op-e2e A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #6909 (246411c) into develop (9d9a79a) will decrease coverage by 2.22%.
Report is 35 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 246411c differs from pull request most recent head f791445. Consider uploading reports for the commit f791445 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6909      +/-   ##
===========================================
- Coverage    44.84%   42.62%   -2.22%     
===========================================
  Files          376      337      -39     
  Lines        29555    28358    -1197     
  Branches      1692     1541     -151     
===========================================
- Hits         13254    12089    -1165     
- Misses       14859    14861       +2     
+ Partials      1442     1408      -34     
Flag Coverage Δ
bedrock-go-tests 47.87% <ø> (+<0.01%) ⬆️
cannon-go-tests ?
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests ?
sdk-next-tests 41.75% <ø> (ø)
sdk-tests 41.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-challenger/config/config.go 96.25% <ø> (ø)

... and 48 files with indirect coverage changes

@clabby clabby force-pushed the clabby/ctb/game-type-parity branch from a78ab45 to 07a5499 Compare August 18, 2023 19:38
@mergify mergify bot added the A-op-challenger Area: op-challenger label Aug 18, 2023
@clabby clabby marked this pull request as ready for review August 18, 2023 19:38
@clabby clabby requested review from a team as code owners August 18, 2023 19:38
@clabby clabby requested review from ajsutton and maurelian August 18, 2023 19:38
@clabby clabby added the M-mergify-ignore Meta: Stops Mergify from automatically merging label Aug 18, 2023
@clabby clabby requested a review from trianglesphere August 18, 2023 19:39
@clabby clabby changed the title Preserve prod game type space feat(ctb): Preserve prod game type space Aug 18, 2023
@clabby clabby force-pushed the clabby/ctb/game-type-parity branch from 2ae988a to 246411c Compare August 18, 2023 20:52
@trianglesphere trianglesphere added the M-do-not-merge Meta: Do not merge label Aug 18, 2023
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but probably worth updating the op-challenger/scripts/alphabet/init_script.sh to have the new alphabet game type as well.

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Aug 21, 2023

Semgrep found 1 todos_require_linear finding:

  • op-e2e/setup.go: L421

Please create a Linear ticket for this TODO.

Ignore this finding from todos_require_linear.

Semgrep found 1 leaky-time-after finding:

  • op-challenger/fault/monitor.go: L24-35

Leaky use of time.After in for-select, see: https://groups.google.com/g/golang-nuts/c/cCdm0Ixwi9A/m/jMiJJScAEAAJ

Ignore this finding from leaky-time-after.

@clabby clabby removed M-do-not-merge Meta: Do not merge M-mergify-ignore Meta: Stops Mergify from automatically merging labels Aug 21, 2023
@clabby clabby merged commit bcfbee5 into develop Aug 21, 2023
@clabby clabby deleted the clabby/ctb/game-type-parity branch August 21, 2023 15:46
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Aug 21, 2023
@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-challenger Area: op-challenger A-op-e2e Area: op-e2e A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants