-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ops: Add new contributor guide #6890
Conversation
7694d5b
to
18fa4be
Compare
Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review. |
18fa4be
to
180786e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6890 +/- ##
===========================================
+ Coverage 44.81% 47.74% +2.93%
===========================================
Files 376 308 -68
Lines 29535 23324 -6211
Branches 1692 0 -1692
===========================================
- Hits 13236 11137 -2099
+ Misses 14859 11172 -3687
+ Partials 1440 1015 -425
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I forgot you were in the process of doing this and started a quick stack to pull contributing docs into the new top level docs/
directory. If we want to go this route, I can rebase my stack on top of this PR. I think it makes sense to do this since we can split up the guide into a number of specific sub-documents addressing things like ci, labeling, pull request, issues, etc etc.
Also, nice h/t to reth at the bottom 😛
This PR has been added to the merge queue, and will be merged soon. |
Added the
M-mergify-ignore
|
Closing this since we have a new draft. |
No description provided.