Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops: Add new contributor guide #6890

Closed
wants to merge 1 commit into from
Closed

Conversation

mslipper
Copy link
Collaborator

No description provided.

@mslipper mslipper changed the title ops: Add new contirbutor guide ops: Add new contributor guide Aug 17, 2023
@mslipper mslipper requested a review from tynes August 17, 2023 22:49
@mslipper mslipper force-pushed the feat/contributor-guide branch from 7694d5b to 18fa4be Compare August 17, 2023 22:49
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the S-conflict Status: A conflict is present label Aug 17, 2023
@mslipper mslipper force-pushed the feat/contributor-guide branch from 18fa4be to 180786e Compare August 17, 2023 22:53
@mergify mergify bot removed the S-conflict Status: A conflict is present label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #6890 (180786e) into develop (7f06ed8) will increase coverage by 2.93%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6890      +/-   ##
===========================================
+ Coverage    44.81%   47.74%   +2.93%     
===========================================
  Files          376      308      -68     
  Lines        29535    23324    -6211     
  Branches      1692        0    -1692     
===========================================
- Hits         13236    11137    -2099     
+ Misses       14859    11172    -3687     
+ Partials      1440     1015     -425     
Flag Coverage Δ
bedrock-go-tests 47.74% <ø> (-0.09%) ⬇️
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 80 files with indirect coverage changes

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I forgot you were in the process of doing this and started a quick stack to pull contributing docs into the new top level docs/ directory. If we want to go this route, I can rebase my stack on top of this PR. I think it makes sense to do this since we can split up the guide into a number of specific sub-documents addressing things like ci, labeling, pull request, issues, etc etc.

Also, nice h/t to reth at the bottom 😛

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Aug 18, 2023
@refcell refcell added the M-mergify-ignore Meta: Stops Mergify from automatically merging label Aug 18, 2023
@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Aug 18, 2023
@refcell
Copy link
Contributor

refcell commented Aug 18, 2023

Added the M-mergify-ignore Meta: Stops Mergify from automatically merging label to give @tynes (or others) a chance to review.

@mslipper
Copy link
Collaborator Author

Closing this since we have a new draft.

@mslipper mslipper closed this Aug 22, 2023
@mslipper mslipper deleted the feat/contributor-guide branch October 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-mergify-ignore Meta: Stops Mergify from automatically merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants