Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base Mainnet chain ID and contracts #6315

Merged

Conversation

wilsoncusack
Copy link
Contributor

Description

Adding Base Mainnet chain ID to the L2ChainID enum in types and the L1 contract info to CONTRACT_ADDRESSES. Contracts sourced from https://docs.base.org/network-information#l1-contract-addresses

Tests

No tests, just type changes.

Additional context

Add any other context about the problem you're solving.

Metadata

@wilsoncusack wilsoncusack requested a review from a team as a code owner July 17, 2023 18:05
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 78ddf84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 78ddf84
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64b584e8529e990008785da1

@mergify mergify bot added the sdk label Jul 17, 2023
@mergify mergify bot requested a review from roninjin10 July 17, 2023 18:06
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #6315 (78ddf84) into develop (d7b9cac) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6315      +/-   ##
===========================================
- Coverage    44.64%   44.49%   -0.15%     
===========================================
  Files          432      432              
  Lines        28977    28978       +1     
  Branches       712      712              
===========================================
- Hits         12937    12894      -43     
- Misses       14975    15017      +42     
- Partials      1065     1067       +2     
Flag Coverage Δ
bedrock-go-tests 43.63% <ø> (-0.01%) ⬇️
cannon-go-tests 62.58% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 50.05% <ø> (-4.40%) ⬇️
core-utils-tests 49.06% <ø> (ø)
fault-detector-tests 26.95% <ø> (ø)
sdk-next-tests 42.48% <100.00%> (+0.03%) ⬆️
sdk-tests 42.48% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/utils/chain-constants.ts 100.00% <ø> (ø)
packages/sdk/src/interfaces/types.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype! Congrats on the launch

packages/sdk/src/utils/chain-constants.ts Show resolved Hide resolved
@roninjin10 roninjin10 merged commit ea1162e into ethereum-optimism:develop Jul 17, 2023
nitaliano pushed a commit that referenced this pull request May 20, 2024
Add Base Mainnet chain ID and contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] add BASE mainnet support in the SDK
2 participants