Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename: proxyAdminOwner -> superchainProxyAdminOwner #12106

Merged
merged 5 commits into from
Sep 25, 2024
Merged

rename: proxyAdminOwner -> superchainProxyAdminOwner #12106

merged 5 commits into from
Sep 25, 2024

Conversation

blmalone
Copy link
Contributor

rename: proxyAdminOwner -> superchainProxyAdminOwner

fix: renames in tests.

@blmalone blmalone marked this pull request as ready for review September 25, 2024 12:33
@blmalone blmalone requested a review from a team as a code owner September 25, 2024 12:33
@blmalone blmalone requested review from AmadiMichael and removed request for a team September 25, 2024 12:33
@blmalone blmalone mentioned this pull request Sep 25, 2024
Merged
@blmalone Graphite App
Copy link
Contributor Author

blmalone commented Sep 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone mentioned this pull request Sep 25, 2024
Merged
@blmalone blmalone requested review from mds1 and removed request for AmadiMichael September 25, 2024 12:34
@blmalone blmalone requested review from a team as code owners September 25, 2024 12:53
@blmalone blmalone requested review from axelKingsley and removed request for a team September 25, 2024 12:53
@blmalone blmalone mentioned this pull request Sep 25, 2024
Merged
Base automatically changed from 09-24-rename_opstackmanafer_-_opcontractsmanager to develop September 25, 2024 15:18
@blmalone blmalone force-pushed the 09-25-rename_proxyadminowner_-_superchainproxyadminowner branch from 19257da to 0fca78a Compare September 25, 2024 15:19
@blmalone blmalone requested a review from mds1 September 25, 2024 15:20
@blmalone blmalone enabled auto-merge September 25, 2024 17:51
@blmalone blmalone force-pushed the 09-25-rename_proxyadminowner_-_superchainproxyadminowner branch from 0fca78a to 29b2268 Compare September 25, 2024 18:16
@blmalone blmalone mentioned this pull request Sep 25, 2024
Merged
@blmalone blmalone added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 36180d7 Sep 25, 2024
63 of 64 checks passed
@blmalone blmalone deleted the 09-25-rename_proxyadminowner_-_superchainproxyadminowner branch September 25, 2024 19:28
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@blmalone @samlaf
rename: proxyAdminOwner -> superchainProxyAdminOwner (ethereum-optimi…
67cf6ef 
…sm#12106)

* rename: proxyAdminOwner -> superchainProxyAdminOwner

* fix: renames in tests.

* fix: renaming in go code.

* fix: Changing the intent to contain SuperchainProxyAdminOwner instead of just ProxyAdminOwner

* fix: reverting last change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@mslipper mslipper mslipper approved these changes

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley is a code owner automatically assigned from ethereum-optimism/op-stack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blmalone @mslipper @mds1