Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show log for devnet #12102

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

zhiqiangxu
Copy link
Contributor

It seems devnet logs are gone ever since this PR.

This PR makes devnet logs show again.

@zhiqiangxu zhiqiangxu requested review from a team as code owners September 25, 2024 09:56
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a comment to this import. I can see someone removing this again in the future as its purpose isn't clear.

@zhiqiangxu
Copy link
Contributor Author

Worth adding a comment to this import. I can see someone removing this again in the future as its purpose isn't clear.

Good point, done.

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Inphi Inphi added this pull request to the merge queue Sep 25, 2024
Merged via the queue into ethereum-optimism:develop with commit da9bc72 Sep 25, 2024
65 checks passed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* show log for devnet

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants