Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop(crossl2inbox): revert on deposits for validateMessage #12088

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hamdiallam
Copy link
Contributor

@hamdiallam hamdiallam commented Sep 24, 2024

interop messages are not allowed on deposits. this check should also happen on validateMessage

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hamdiallam and the rest of your teammates on Graphite Graphite

@hamdiallam hamdiallam changed the title check deposit on validateMessage interop(crossl2inbox): revert on deposits on validateMessage Sep 24, 2024
Copy link
Contributor

semgrep-app bot commented Sep 24, 2024

Semgrep found 1 sol-style-return-arg-fmt finding:

  • packages/contracts-bedrock/src/libraries/Blueprint.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@hamdiallam hamdiallam marked this pull request as ready for review September 24, 2024 16:39
@hamdiallam hamdiallam requested a review from a team as a code owner September 24, 2024 16:39
@hamdiallam hamdiallam changed the title interop(crossl2inbox): revert on deposits on validateMessage interop(crossl2inbox): revert on deposits for validateMessage Sep 24, 2024
@tynes
Copy link
Contributor

tynes commented Sep 24, 2024

Needs semver lock updates

@hamdiallam hamdiallam force-pushed the crossl2inbox.deposit.fix branch 2 times, most recently from 1d0b5a1 to 4c6d640 Compare September 24, 2024 22:46
@hamdiallam hamdiallam force-pushed the crossl2inbox.deposit.fix branch from 4c6d640 to ce440fe Compare September 24, 2024 23:18
@hamdiallam hamdiallam added this pull request to the merge queue Sep 24, 2024
Merged via the queue into develop with commit 22094b4 Sep 24, 2024
64 checks passed
@hamdiallam hamdiallam deleted the crossl2inbox.deposit.fix branch September 24, 2024 23:38
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants