-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-kontrol: optimize the doc #12065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@smartcontracts Is this right? |
AmadiMichael
reviewed
Oct 7, 2024
smartcontracts
approved these changes
Oct 23, 2024
Hi, apologies for the delay here, would you mind rebasing this PR? |
@smartcontracts rebased, thanks! |
/ci authorize 690383a |
Thanks! Merging :-) |
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 24, 2024
03e0b88
49 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* optimize the doc * small fix * reomve outdated content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the document more neutral to reduce misunderstandings.
Similar to #12054, DeploymentSummary.t.sol has been removed, using it as an example in this document here would be very confusing.