Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-kontrol: optimize the doc #12065

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

rickck11
Copy link
Contributor

Make the document more neutral to reduce misunderstandings.

Similar to #12054, DeploymentSummary.t.sol has been removed, using it as an example in this document here would be very confusing.

@rickck11 rickck11 requested a review from a team as a code owner September 23, 2024 19:16
@tynes
Copy link
Contributor

tynes commented Sep 27, 2024

@smartcontracts Is this right?

@rickck11 rickck11 requested a review from AmadiMichael October 7, 2024 08:56
@smartcontracts
Copy link
Contributor

Hi, apologies for the delay here, would you mind rebasing this PR?

@rickck11 rickck11 closed this Oct 23, 2024
@rickck11 rickck11 deleted the patch-5 branch October 23, 2024 19:34
@rickck11 rickck11 restored the patch-5 branch October 23, 2024 19:34
@rickck11 rickck11 reopened this Oct 23, 2024
@rickck11
Copy link
Contributor Author

@smartcontracts rebased, thanks!

@smartcontracts
Copy link
Contributor

/ci authorize 690383a

@smartcontracts smartcontracts added this pull request to the merge queue Oct 24, 2024
@smartcontracts
Copy link
Contributor

Thanks! Merging :-)

Merged via the queue into ethereum-optimism:develop with commit 03e0b88 Oct 24, 2024
49 checks passed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* optimize the doc

* small fix

* reomve outdated content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants