Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Sanitize op-program for unsupported instructions #12007

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Sep 19, 2024

Cannon doesn't support bgezal and bltzal instructions as they're not emitted by Go. This CI check asserts that this is always the case for the MIPS32 op-program.

@Inphi Inphi requested a review from mbaxter September 19, 2024 15:15
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.20%. Comparing base (a080bd2) to head (52035d3).
Report is 43 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12007      +/-   ##
===========================================
- Coverage    79.43%   79.20%   -0.24%     
===========================================
  Files           41       41              
  Lines         3414     3414              
===========================================
- Hits          2712     2704       -8     
- Misses         532      541       +9     
+ Partials       170      169       -1     
Flag Coverage Δ
cannon-go-tests 79.20% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Inphi Inphi marked this pull request as ready for review September 19, 2024 15:29
@Inphi Inphi requested review from a team as code owners September 19, 2024 15:29
Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎉

@Inphi Inphi added this pull request to the merge queue Sep 24, 2024
Merged via the queue into develop with commit ec3f634 Sep 24, 2024
65 of 67 checks passed
@Inphi Inphi deleted the inphi/sanitize-insn branch September 24, 2024 14:54
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants