-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eth_sendTransaction test compliance #110
Merged
Merged
Changes from 10 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
0e4fb48
pass RevertErrors up in full node
ben-chain 413a98f
revert messages working, receipts not
ben-chain 291a4d5
receipts working for failed txs
ben-chain f5cb2a0
test receipt generation for reverting txns'
ben-chain 60afc74
bugfix, linting
ben-chain 038c2ff
fix eth_call reversion errors
ben-chain 9ce3e33
linting
ben-chain 2102ae3
fix test sendTransaction endpoint to match spec
ben-chain 6be870f
lint
ben-chain 1bd4cfd
Merge branch 'master' into bug/eth_sendTransaction
ben-chain 571a68a
everything working
ben-chain cce8691
linting
ben-chain 9d3fd63
linting
ben-chain 7c1b3cc
bad multi level filter
ben-chain 021917a
handle unsupported filter handler
ben-chain ba3f5de
merge updated error code
ben-chain ebd81f3
linting
ben-chain ec8c861
merge master
ben-chain 36ee32e
fix merge accidents
ben-chain b4bddc1
linting
ben-chain ee41892
linting
ben-chain 96cb62a
fix log indexing bug
ben-chain 051bbfd
add filtering multi-event test
ben-chain 0287a08
merge future master
ben-chain 0ffa719
linting
ben-chain 7baf8d2
linting
ben-chain 212f700
linting
ben-chain cc8f675
Merge branch 'bug/eth_getLogs/incorrect-address' into bug/eth_sendTra…
ben-chain 9b8180c
use already existing EM interface
ben-chain 04fa273
linting
ben-chain 6c4914d
linting
ben-chain 6049829
Preemptive Merge branch 'bug/eth_getLogs/incorrect-address' into bug/…
ben-chain 3de4502
Merge branch 'master' into bug/eth_sendTransaction
ben-chain 5db1f40
remove unused var
ben-chain e3c3e0a
linting
ben-chain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be reverted. If it was used, it'd show up in a diff, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah that's definitely unused