Merge pull request #7859 from ethereum-optimism/aj/monitor-unsubscribe

op-challenger: Unsubscribe from l1 heads on shutdown
ethereum-optimism · Oct 26, 2023 · c46093b · c46093b
2 parents 2372c98 + 20fa6c5
commit c46093b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/op-challenger/game/monitor.go b/op-challenger/game/monitor.go
@@ -141,6 +141,7 @@ func (m *gameMonitor) MonitorGames(ctx context.Context) error {
 	for {
 		select {
 		case <-ctx.Done():
+			m.l1HeadsSub.Unsubscribe()
 			return nil
 		case err, ok := <-m.l1HeadsSub.Err():
 			if !ok {

diff --git a/op-challenger/game/monitor_test.go b/op-challenger/game/monitor_test.go
@@ -100,7 +100,8 @@ func TestMonitorGames(t *testing.T) {
 		defer cancel()
 
 		go func() {
-			waitErr := wait.For(context.Background(), 100*time.Millisecond, func() (bool, error) {
+			// Wait for the subscription to be created
+			waitErr := wait.For(context.Background(), 5*time.Second, func() (bool, error) {
 				return mockHeadSource.sub != nil, nil
 			})
 			require.NoError(t, waitErr)