Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: dependabot-style PRs when the ethereum-json-rpc-spec changes #15

Closed
meowsbits opened this issue Feb 19, 2020 · 3 comments
Closed

Feat: dependabot-style PRs when the ethereum-json-rpc-spec changes #15

meowsbits opened this issue Feb 19, 2020 · 3 comments
Labels
M6-API:RPC 📣 P7-nicetohave 🐕

Comments

@meowsbits
Copy link
Contributor

meowsbits commented Feb 19, 2020 •
edited
Loading

Migrated from: etclabscore/multi-geth-fork#103
Original author: @BelfordZ

rel #99
@ziogaschr
Copy link
Member

How do we check for spec updates? Is this just a document in a repo? Maybe we can use wei/pull GitHub Action here as well.

If not, can you share more info, as I can work on it if you like @meowsbits.

@meowsbits
Copy link
Contributor Author

meowsbits commented Jan 12, 2021 •
edited
Loading

Hm.. this issue is an old and probably stale one.

Since this issue was created we've added support for OpenRPC by reflection (which includes the spec'd methods). The dependabot PRs would have been useful if we wanted to update a static file (basically, the spec) that geth would serve at rpc.discover, but that's not really relevant or sensible anymore.

If the spec changes and becomes incompatible with ours (since we meet it currently), then I would say it's up to the spec to bump their version number accordingly, and core-geth then until updating would just be implementing an older version.

If we really want to be serious about assuring core-geth is aligned with the spec, then what comes to mind is a test that would curl the raw JSON spec and validate core-geth's rpc.discover result against it. Actually just typing this out loud starts to seem like a pretty decent test for the rpc.discover implementation anyways.

ziogaschr added a commit that referenced this issue Jan 12, 2021
@ziogaschr
node: add test for the discovery endpoint to validate OpenRPC compliance
99780e0 
Rel #15
@ziogaschr ziogaschr mentioned this issue Jan 12, 2021
Merged
ziogaschr added a commit that referenced this issue Jan 14, 2021
@ziogaschr
node: add test for the discovery endpoint to validate OpenRPC complia…
adcd3eb 
…nce (#295)

* node: add test for the discovery endpoint to validate OpenRPC compliance
* node: add test that runs only on CI for comparing local OpenRPC spec with the latest published spec

Rel #15
@ziogaschr
Copy link
Member

@meowsbits I think we can close this one based on #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M6-API:RPC 📣 P7-nicetohave 🐕
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ziogaschr @meowsbits