Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: don't convert byte slice to string when using verb %s #17878

Merged
merged 1 commit into from
Apr 26, 2024
Merged

all: don't convert byte slice to string when using verb %s #17878

merged 1 commit into from
Apr 26, 2024

Conversation

callthingsoff
Copy link
Contributor

This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @callthingsoff. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice

Signed-off-by: Jes Cok <[email protected]>
@ivanvc
Copy link
Member

ivanvc commented Apr 25, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented Apr 25, 2024

/retest

1 similar comment
@ivanvc
Copy link
Member

ivanvc commented Apr 26, 2024

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@callthingsoff
Copy link
Contributor Author

Thanks, cc @serathius @siyuanfoundation

@serathius serathius merged commit 0bd7008 into etcd-io:main Apr 26, 2024
45 checks passed
@callthingsoff callthingsoff deleted the omit_conversion_using_verb_s branch April 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants