Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive-typescript: update dependencies #1564

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Aug 15, 2024

Description:

Updates the dependencies of the derive-typescript crate (ran cargo update),
and also makes some required modifications to the tests to get the build to
work.

The image built from this should bring in the protocol changes from bba5ae4.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@williamhbaker williamhbaker force-pushed the wb/update-derive-typescript branch from f10380d to 048f734 Compare August 15, 2024 21:28
Updates the dependencies of the derive-typescript crate (ran `cargo update`),
and also makes some required modifications to the tests to get the build to
work.

The image built from this should bring in the protocol changes from bba5ae4.
@williamhbaker williamhbaker force-pushed the wb/update-derive-typescript branch from 048f734 to 3c315be Compare August 15, 2024 21:28
@williamhbaker williamhbaker marked this pull request as ready for review August 15, 2024 21:29
@williamhbaker williamhbaker changed the title derive-typescript: update time dependency derive-typescript: update dependencies Aug 16, 2024
@williamhbaker
Copy link
Member Author

I had originally titled this pull request as an update to only the time dependency which was initially causing a problem, but had to expand it to doing a more general dependency update + pulling in the latest Flow version from the master branch.

Since the automated tests for derive-typescript don't seem super comprehensive I also ran some local tests with a docker image built from this branch, running it on a local stack and making sure the various ops derivations still work as expected.

Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit 7d68a3b into master Aug 16, 2024
4 checks passed
@williamhbaker williamhbaker deleted the wb/update-derive-typescript branch August 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants