Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound appender tests #355

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

bconn98
Copy link
Collaborator

@bconn98 bconn98 commented Mar 3, 2024

Hard code make_temp_file_name to 0 in the test config to allow for a consistent testing environment.

@bconn98 bconn98 requested review from estk and gadunga as code owners March 3, 2024 01:55
@bconn98 bconn98 force-pushed the compound_appender_tests branch from 3df803a to 7ae8409 Compare March 3, 2024 02:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.15%. Comparing base (c981ca4) to head (7ae8409).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   63.01%   66.15%   +3.14%     
==========================================
  Files          24       24              
  Lines        1560     1557       -3     
==========================================
+ Hits          983     1030      +47     
+ Misses        577      527      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants