Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isort as a pre-commit hook #86

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Isort as a pre-commit hook #86

merged 3 commits into from
Feb 26, 2021

Conversation

ebadkamil
Copy link
Contributor

Added isort as a pre-commit hook. Is it ok?

@ebadkamil ebadkamil requested a review from mattclarke February 25, 2021 15:01
ebadkamil
ebadkamil commented Feb 25, 2021
View reviewed changes
.pre-commit-config.yaml
rev: 5.7.0
hooks:
- id: isort
args: ["--profile", "black"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to resolve conflict between black and isort

PyCQA/isort#1518 (comment)

@mattclarke
Copy link
Member

I'm pretty certain this is fine, so if @matthew-d-jones is happy I say we merge it despite the (known) issue with the build.

matthew-d-jones
matthew-d-jones approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@matthew-d-jones matthew-d-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fine with me.
The problem is lack of disk space on system test node? Is someone dealing with that?

@matthew-d-jones
Copy link
Contributor

@ebadkamil Sorry, after merging your other PR there are some merge conflicts to solve.

@ebadkamil
Copy link
Contributor Author

ebadkamil commented Feb 26, 2021 •
edited
Loading

No worries. Now conflicts are fixed

@matthew-d-jones matthew-d-jones merged commit 2bba63c into main Feb 26, 2021
@matthew-d-jones matthew-d-jones deleted the pre_commit_hook branch February 26, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-d-jones matthew-d-jones matthew-d-jones approved these changes

@mattclarke mattclarke Awaiting requested review from mattclarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebadkamil @mattclarke @matthew-d-jones