Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1510] rm old docs update links #1342

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[VSC-1510] rm old docs update links #1342

merged 3 commits into from
Nov 19, 2024

Conversation

brianignacio5
Copy link
Collaborator

Description

  • Remove GitHub documentation in favor of Espressif documentation.
  • Update documentation links in README.md
  • Add basic setup for zh_CN language build and update CI to include both.

Type of change

  • This change requires a documentation update

Steps to test this pull request

Open Preview documentation link in this PR. Review documentation in Chinese.

Test readme links and extension links are updated.

How has this been tested?

Test by click links in read and extension links. Check preview documentation that zh_CN is generated.

Test Configuration:

  • ESP-IDF Version: Not relevant
  • OS (Windows,Linux and macOS): Not related

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the documentation 📝 Solely about the documentation of the project. label Nov 13, 2024
@brianignacio5 brianignacio5 self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Fabricio-ESP Fabricio-ESP changed the title rm old docs update links [VSC-1510] rm old docs update links Nov 15, 2024
@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Nov 18, 2024
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good besides the broken code of conduct link.

README.md Outdated Show resolved Hide resolved
@Fabricio-ESP
Copy link
Collaborator

@brianignacio5
Additional to your changes, There are some broken links in the "All Available commands" table, making references to files deleted in this PR. PTAL

Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now.

@brianignacio5 brianignacio5 merged commit 9f645d3 into master Nov 19, 2024
7 checks passed
@brianignacio5 brianignacio5 deleted the docs/rm-old-docs branch November 19, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📝 Solely about the documentation of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants