forked from hathach/tinyusb
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(tusb): Added tusb_teardown() #44
Open
roma-jam
wants to merge
1
commit into
release/v0.17
Choose a base branch
from
feature/tusb_teardown
base: release/v0.17
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roma-jam
changed the title
feature(tusb): Added tusb_teardown API
feature(tusb): Added tusb_teardown()
Dec 11, 2024
roma-jam
force-pushed
the
feature/tusb_teardown
branch
from
December 11, 2024 14:59
ba5a917
to
c46d292
Compare
roma-jam
force-pushed
the
feature/tusb_teardown
branch
from
December 11, 2024 18:23
c46d292
to
3288a79
Compare
roma-jam
force-pushed
the
feature/tusb_teardown
branch
from
December 12, 2024 09:45
3288a79
to
098a223
Compare
tore-espressif
approved these changes
Dec 12, 2024
peter-marcisovsky
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the changes on HW with the test app, works fine. Once this is merged, we can enable the rest of the device tests in CI which depend on the teardown.
roma-jam
force-pushed
the
feature/tusb_teardown
branch
from
December 12, 2024 14:31
098a223
to
8366c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
To change the USB device function or re-initialize the tinyusb stack there should be an option to teardown the lower layer (disable the phy and flush the registers).
The public API for init tinyusb stack for USB Device is
tusb_init(void)
for versions < v0.17, andtusb_rhport_init(rhport, *rh_init)
for verisons >= 0.17.Teardown feature should be implemented as a public API for Device and Host roles and provide the possibility to use the teardown call in both (legacy and new API way)
Description
The same mechanism for legacy call support is used as for
tusb_init()
(providing therhport
asTUD_OPT_RHPORT
orTUH_OPT_RHPORT
but not the function argument)Limitations
Breaking change
No breaking changes
Testing:
Implemented in espressif/esp-usb#39
Checklist
Related issues