Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(esp_tinyusb): Run esp_tinyusb test apps in CI on esp32s2 runner #75

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky commented Oct 8, 2024

Description

This MR enables esp_tinyusb tests in CI on a new usb_device esp32s2 runner

In esp_tinyusb, there are 3 groups of tests:

  • pytest_cdc.py - Test is run in CI
  • pytest_usb_device.py - Test not run in CI, missing teradown function in tinyusb
  • pytest_vendor.py - Test not run in CI due to Docker container problems accessing a vendor specific device

Related

  • IDF-11683 Run esp_tinyusb tests on esp32s2 in GH CI

Testing

To pass the CI


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky peter-marcisovsky self-assigned this Oct 8, 2024
@peter-marcisovsky peter-marcisovsky force-pushed the ci/run_esp_tinyusb_in_ci branch 2 times, most recently from 2f34057 to 91e8cb9 Compare October 10, 2024 16:15
@peter-marcisovsky peter-marcisovsky changed the title ci(esp_tinyusb): Run esp_tinyusb test apps in CI ci(esp_tinyusb): Run esp_tinyusb test apps in CI on esp32s2 runner Nov 13, 2024
@peter-marcisovsky peter-marcisovsky added the Status: Reviewing Issue is being reviewed label Nov 13, 2024
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peter-marcisovsky LGTM! thanks for this great work.

I updated the branch protection rules, so we can merge now :)

device/esp_tinyusb/test_apps/README.md Outdated Show resolved Hide resolved
    - New CI target runner esp32s2 usb_device
    - Runner setup to allow docker container an access to USB devices
@tore-espressif tore-espressif merged commit 5510758 into master Nov 15, 2024
25 checks passed
tore-espressif added a commit that referenced this pull request Nov 15, 2024
In #75 we refactored the test runners' configuration.
We want to run the test more frequently so we can evaluate their stability.

This entire commit can be reverted after the evaluation period is over (in couple of weeks).
@peter-marcisovsky peter-marcisovsky added Status: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Nov 15, 2024
@peter-marcisovsky peter-marcisovsky deleted the ci/run_esp_tinyusb_in_ci branch December 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants