Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_modem: Ignore format warnings (IDFGH-7760) #73

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

Lapshin
Copy link
Contributor

@Lapshin Lapshin commented Jul 6, 2022

This is the first step to fix IDF's format warnings.

IDF has globally enabled compiler option -Wno-format. The fix will be in three steps:

  1. add -Wno-format to affected components
  2. disable the global option -Wno-format
  3. fix format warnings for each component

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title esp_modem: Ignore format warnings esp_modem: Ignore format warnings (IDFGH-7760) Jul 6, 2022
@igrr
Copy link
Member

igrr commented Jul 6, 2022

@Lapshin same request as in the other PR: please bump the patch version in idf_component.yml and open an issue to track fixing these warnings.

@Lapshin Lapshin force-pushed the fix/ignore-format-warnings branch 3 times, most recently from 966201c to 802f1b9 Compare July 7, 2022 08:07
@Lapshin Lapshin mentioned this pull request Jul 7, 2022
2 tasks
@Lapshin Lapshin force-pushed the fix/ignore-format-warnings branch from 802f1b9 to e8145fc Compare July 12, 2022 08:32
@david-cermak david-cermak merged commit 82b1aa9 into espressif:master Jul 12, 2022
@Lapshin Lapshin mentioned this pull request Jul 12, 2022
@gabsuren
Copy link
Contributor

Fixed in #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants