feat(mdns): support update subtype (IDFGH-14068) #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zwx1995esp
force-pushed
the
feat/support_add_remove_subtype
branch
from
56d8d0a to
6ff73a8
Compare
zwx1995esp
force-pushed
the
feat/support_add_remove_subtype
branch
2 times, most recently
from
e1ba831 to
85d3787
Compare
zwx1995esp
commented
Nov 12, 2024
zwx1995esp
force-pushed
the
feat/support_add_remove_subtype
branch
from
85d3787 to
3183a06
Compare
david-cermak
approved these changes
Nov 13, 2024
Hi, @david-cermak Thanks for your quick responsing and reviewing. I will resolve the commends ASAP. |
github-actions
bot
changed the title
zwx1995esp
force-pushed
the
feat/support_add_remove_subtype
branch
from
3183a06 to
062b8dc
Compare
david-cermak
approved these changes
Nov 14, 2024
Merged
espressif-bot
added
Status: Done
Resolution: Done
and removed
Status: Opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the subtype related API has only one for adding a subtype on some services. This PR introduces new APIs to add/remove/update the subtypes in the mdns service. Also current logic will send nothing on the netif when there is a new subtype added, this PR announces the multicast query response on each netif when a new or a series of subtypes are added.
Related
Testing
avahi, checked the PTR answer using wireshark.