-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(websocket): Support DS peripheral for mutual TLS (IDFGH-12285) #520
Open
johanstokking
wants to merge
1
commit into
espressif:master
Choose a base branch
from
johanstokking:feature/websocket/client_ds_data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(websocket): Support DS peripheral for mutual TLS (IDFGH-12285) #520
johanstokking
wants to merge
1
commit into
espressif:master
from
johanstokking:feature/websocket/client_ds_data
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
feat(websocket): Support DS peripheral for mutual TLS
feat(websocket): Support DS peripheral for mutual TLS (IDFGH-12285)
Mar 6, 2024
johanstokking
commented
Mar 6, 2024
@@ -519,6 +522,10 @@ static esp_err_t esp_websocket_client_create_transport(esp_websocket_client_hand | |||
} else { | |||
esp_transport_ssl_set_client_key_data_der(ssl, client->config->client_key, client->config->client_key_len); | |||
} | |||
#if CONFIG_ESP_TLS_USE_DS_PERIPHERAL | |||
} else if (client->config->client_ds_data) { | |||
esp_transport_ssl_set_ds_data(ssl, client->config->client_ds_data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature here is:
void esp_transport_ssl_set_ds_data(esp_transport_handle_t t, void *ds_data)
Hence I'm using void *
and not esp_ds_data_ctx_t *
to avoid a dependency on Mbed TLS.
johanstokking
force-pushed
the
feature/websocket/client_ds_data
branch
from
March 8, 2024 09:28
a5c52f9
to
6ada58d
Compare
@gabsuren Can you shed some light on this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fantastic project guys. Here's something I use that you might want to take into consideration: supporting the DS peripheral for mutual TLS.
Example usage with https://github.com/espressif/esp_secure_cert_mgr/:
I considered adding this to the example project, but I feel like it gets bloated quickly with dependencies and ifdefs.