Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(preview): pass PR number to deploy-preview via artifacts #361

Conversation

f-hollow
Copy link
Collaborator

Description

This PR adds the logic to pass the PR number from build-preview to deploy-preview via artifacts due to the issue GitHub Action pull_request attribute empty in workflow_run event object for PR from forked repo.

Related

Testing

Testing was done in this PR


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@f-hollow
Copy link
Collaborator Author

Testing has been done, so I will merge it without reviews.

@f-hollow f-hollow merged commit eb32ae0 into espressif:main Dec 11, 2024
4 checks passed
@f-hollow f-hollow deleted the ci/pass_pr_number_to_deploy-preview_via_artifacts branch December 11, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant