Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic 2 channel wifi curtain module based on BK7231N #806

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add generic 2 channel wifi curtain module based on BK7231N #806

wants to merge 7 commits into from

Conversation

W-y-v-e-r-n
Copy link

  • index.md added for the new device
  • photos from the device and its inside added
  • new device type: Covers
  • modified sidebar.yml

@W-y-v-e-r-n
Add files via upload
56e05b9
@W-y-v-e-r-n
add generic 2 channel wifi curtain module based on BK7231N
423ecb5 
- index.md added for the new device
@W-y-v-e-r-n
generic 2 channel wifi curtain module
ce9347c 
- photos from the device and its inside added
@W-y-v-e-r-n
Update sidebar.yml
7c04bd6 
Updated sidebar.yml to have new device type: Covers
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 4713272
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/66bc72b91a7aed0008c0dae4
😎 Deploy Preview https://deploy-preview-806--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🔴 down 7 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 75 (🔴 down 6 from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tekmaven
Copy link
Collaborator

tekmaven commented Sep 7, 2024

Could you just use type: misc?

tekmaven
tekmaven requested changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@tekmaven tekmaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the other changes besides the new device and set the device to type misc. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekmaven tekmaven tekmaven requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-y-v-e-r-n @tekmaven