-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating tasks for starting/finishing the connection #826
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2433 2434 +1
=========================================
+ Hits 2433 2434 +1 ☔ View full report in Codecov by Sentry. |
We end up creating a lot of tasks when the device is in deep sleep since its trying to reconnect. We can replace them with
async_interrupt
and futures. This simplifies the connection process and reduces the chance for races.This also speeds up connections because we don't end up with 3 tasks to make a connection anymore, only 1