Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override ldproxy install without prompting #27

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Override ldproxy install without prompting #27

merged 1 commit into from
Sep 10, 2024

Conversation

UnTraDe
Copy link
Contributor

@UnTraDe UnTraDe commented Aug 25, 2024 •
edited
Loading

When running this action again on the same runner, it fails when unzipping ldproxy because it asks if it should override existing file:
image

This PR just adds the -o flag to the unzip command, telling it to overwrite without prompting.

SergioGasquez
SergioGasquez approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes LGTM! Mind rebasing so we can get CI green?

jessebraham
jessebraham approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham merged commit cffabd7 into esp-rs:main Sep 10, 2024
2 checks passed
@UnTraDe
Copy link
Contributor Author

UnTraDe commented Sep 10, 2024

Thanks!
Any plans to release a new version soon? I prefer to use uses: esp-rs/[email protected] instead of uses: esp-rs/xtensa-toolchain@main :)

@SergioGasquez
Copy link
Member

Just released v1.5.3 and also updated the v1.5 tag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UnTraDe @SergioGasquez @jessebraham