Build: add node v17 #15193
Merged
Build: add node v17 #15193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
aladdin-add
added
accepted
|
blocked by gajus/eslint-plugin-jsdoc#791 update: fixed in 72e4b53 |
bmish
approved these changes
Oct 20, 2021
nzakas
approved these changes
Oct 20, 2021
nzakas
reviewed
Oct 21, 2021
| @@ -43,10 +43,10 @@ jobs: | |||
| - name: Install Packages | |||
| run: npm install | |||
| # TODO(btmills): Remove Node 16 --force branching after releasing v8.0.0 final. | |||
| if: ${{ !startswith(matrix.node, '16') }} | |||
| if: ${{ !startswith(matrix.node, '16') && !startswith(matrix.node, '17') }} | |||
There was a problem hiding this comment.
The comment above this line indicates we should be able to remove all checks for Node 16? So we probably don’t need to add Node 17, just remove the Node 16 stuff?
There was a problem hiding this comment.
As seen in here, eslint-plugin-jsdoc has not not fully supported eslint v8 yet. We will have to wait it been fixed: gajus/eslint-plugin-jsdoc#791
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
no.